Open
Conversation
Collaborator
|
I'm not sure what's best. This is an important method, so we would break a lot of code. Maybe we just live with it and find a new name for the Session yielding transaction? |
Contributor
I'm not sure I agree with this. If we switch to yielding a session, what happens if you commit the session inside the transaction? To me this indicates that |
Collaborator
|
We could play some tricks to not allow you to commit explicitly, or to detect that you did and do nothing on block exit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repository only knows about Sessions, so Repository.transaction should yield a Session.
I am raising a DeprecationWarning, though we could instead make a breaking change.